Sam Wilson
Sam Wilson
There seems to be a bug in `eipw`. Try making "ERC-7785" a link.
I haven't looked at the PR yet, so consider this feedback on the stated design. Should this be a command-line option, something embedded in the file itself, or maybe different...
EIP-4750 actually brings up a good argument in favour of per-file hardforks, or at least supported version ranges. Say I write a library that defines several EIP-4750 subroutines. As I...
Yeah, you're absolutely right. I think we actually need two pieces for sound hardfork selection: the target hardfork eas is assembling for, and the range of forks supported by each...
> But it's just an idea. More inspiration [here](https://en.wikipedia.org/wiki/Directive_(programming)) Even more inspiration: https://www.nasm.us/xdoc/2.13.03/html/nasmdoc6.html NASM seems to use square brackets for directives, wrapped in macros for ease of use. For us,...
> I think the correct approach would be to require this directive to be mandatory at the beginning of the root file passed to the compiler and then only in...
I don't even think we need new syntax for this then. `%import(...)` and `%include(...)` already error if they can't find the file, so `%hardfork(...)` fits right in.
You can find my review queue here: https://eipsinsight.com/boards
You'll just need to fix the issues identified by `eipw` and remove that external link.
We have decided against allowing links to Blockchain Commons for the time being.