Sam Wilson

Results 309 comments of Sam Wilson

We'll get around to this eventually. Thanks for the report!

Thanks for the contribution! I think this is a better fit for a library instead of a standard, and might be better as a part of OpenZeppelin (or similar library.)

> Hardcoded regexes in lib.rs are kind of a style for the whole file, I followed the pattern. If we need to change regexes in config files, we need to...

I've added a test in https://github.com/ethereum/eipw/pull/99/commits/09d7de74228d6daffc408655b6bf7b479eb5e8c6 that demonstrates the problem I brought up in https://github.com/ethereum/eipw/pull/99#discussion_r1664272030.

If you're using rustup, you can use, for example, `cargo +1.69 build` to pick a particular version. I'll update the rust version in a separate PR.

This is pretty much it. Take the attached input, and fix the panic. Any fixes would be very appreciated!

Yep! And if you wouldn't mind adding a row to the readme, and an HTML file in the docs folder, I'd appreciate it!

This should be a separate lint from `markdown-rel-links`. Maybe it could be `markdown-must-hyperlink` or something? The name isn't too important. So the full scope of work is: - Add the...

I've added a bit more detail to the initial issue. Hopefully that makes it more clear!