Sam Wilson

Results 308 comments of Sam Wilson

Sorry for taking so long to get back to you! I've been giving this a bit of thought, and I'm really not sure what the best approach is going forward....

It looks like this is caused by the bytes after the invalid instruction. I haven't looked into why yet, but if you remove that, `ecfg` generates a graph: ![image](https://user-images.githubusercontent.com/57262657/172085837-df389ba8-deb4-48f5-8233-0bc880645905.png) ---...

> ecfg probably sees invalid instruction as a termination of one particular block and starts the next block from the next instruction. Yep, that's correct. > These nodes with non-static...

I don't think `JUMP` and `JUMPI` support immediate arguments. IMO we should have a `one mnemonic == one opcode` rule.

I am firmly against allowing most, if not all, of these links. I am also against changing the wording to `MUST` instead of `SHOULD`. Yes, `eipw` strictly enforces the rules,...

> @SamWilsn I think manually override for final EIPs is okay, but for EIPs still being actively worked on - we should just add `ethereum/consensus-specs` to an allow list in...

I am strongly against any policy that allows links to mutable resources. I'd even possibly argue for removing `discussions-to` from final proposals. I am fine with links to **files** in...

What's your preference @Pandapip1 between this and #5757? Personally, I'd like to close this PR and open a similar one when we have the sources policy merged.

EIP-1 would still have the authoritative list of permitted sources

I thought `Withdrawn` EIPs were immutable?