Sam Wilson
Sam Wilson
Should this be a warning or error? Did you have a particular implementation in mind? Parse as markdown, make sure there aren't any HTML tags in the output?
Ha, this author is really doing some good QA :rofl: IMO, `eipw` shouldn't check whether the `discussion-to` link exists, just that it's on Ethereum Magicians. The link proofer should be...
@Pandapip1 Are you talking about: https://github.com/ethereum/eipw/blob/b4c2124aecbb0b91241748ae4cf968b4d49080f2/eipw-lint/src/lib.rs#L91 Or: https://github.com/ethereum/eipw/blob/b4c2124aecbb0b91241748ae4cf968b4d49080f2/eipw-lint/src/lib.rs#L99
Ohh, my bad. That would be: https://github.com/ethereum/eipw/blob/4e4bc7b50a094ea9b02551113780b380a096120d/eipw-lint/src/lib.rs#L357 Why do you want it changed?
Those should've been changed to `ERC725X` and `ERC725Y` to refer to the interfaces, in my opinion. I'm not a huge fan of the `EIP-9999G` format since anyone can create one...
Very true!
Some great options have popped up since I made this issue. Notably: - https://github.com/pluots/zspell - https://github.com/elijah-potter/harper
Because of some weirdness with how codespell's docker image handles paths, I've integrated zspell and an English dictionary. Going to leave this open to investigate options for grammar.
One way to implement this would be to lint for `TBD|TODO` and put that at the start of each section's placeholder text.
People re-wrap the text all the time, so doing a string match on something long might not always catch it. I guess I could do a whitespace agnostic search too....