Sam Wilson
Sam Wilson
Looks like there are a couple failing CI steps. You'll want to build your changes with cargo and run the tests too. Something like: ```bash cargo fmt # Formats the...
This command here should let you run the failing test case locally: > ``` > cargo test --all --all-features # Compiles the code, then runs the tests. > ``` There's...
That's a good point!
This paragraph covers those examples: > If the link destination matches the pattern `eip-([^.]*)\.md#.+$`, trigger if the link text does not match `^(EIP|ERC)-\1\s*\S+`, where `\1` is the proposal's number from...
Because it doesn't have a subsection (after the `#` in the link.)
Pretty much. So URLs with a `#` should have `: ...`
`markdown-link-other` should prevent links that look like EIPs/ERCs that don't point to EIPs.
We never decided if we wanted to implement this. I'm happy to close if you've changed your mind though! I still believe that a reference does not necessarily imply a...
Just to confirm what you want here, should `eipw` return a zero exit code (indicating success) or a non-zero exit code (indicating failure) when `last-call-deadline` is missing?
I guess that makes this extremely low priority! I'd still like to eventually include this for consistency with the preamble lints.