discussions-to links must not contain unescaped special characters

Open Pandapip1 opened this issue 3 years ago • 2 comments

See https://github.com/ethereum/EIPs/pull/6172#discussion_r1054679527

Dec 21 '22 18:12 Pandapip1

Ha, this author is really doing some good QA :rofl:

IMO, eipw shouldn't check whether the discussion-to link exists, just that it's on Ethereum Magicians. The link proofer should be able to tell if the thread has been created, right?

Or did the comma get parsed as some kind of array separator, and it made two separate links? In that case, yeah, eipw should be more strict.

Dec 25 '22 17:12 SamWilsn

Or did the comma get parsed as some kind of array separator, and it made two separate links? In that case, yeah, eipw should be more strict.

All special characters, unless escaped (e.g. , being %2C), should be assumed to be invalid.

Dec 25 '22 22:12 Pandapip1