eipw icon indicating copy to clipboard operation
eipw copied to clipboard

Update the regex of the EIP link check

Open SamWilsn opened this issue 3 years ago • 7 comments

@SamWilsn can we update the regex of the EIP link check to as follows:

(?i)eip-[0-9]+\s

Originally posted by @Pandapip1 in https://github.com/ethereum/EIPs/pull/6103#discussion_r1047608873

SamWilsn avatar Dec 16 '22 19:12 SamWilsn

@Pandapip1 Are you talking about:

https://github.com/ethereum/eipw/blob/b4c2124aecbb0b91241748ae4cf968b4d49080f2/eipw-lint/src/lib.rs#L91

Or:

https://github.com/ethereum/eipw/blob/b4c2124aecbb0b91241748ae4cf968b4d49080f2/eipw-lint/src/lib.rs#L99

SamWilsn avatar Dec 16 '22 19:12 SamWilsn

I'm talking about the one that suggests adding links to other EIPs. I'm not sure which it is.

Pandapip1 avatar Dec 17 '22 01:12 Pandapip1

Ohh, my bad. That would be:

https://github.com/ethereum/eipw/blob/4e4bc7b50a094ea9b02551113780b380a096120d/eipw-lint/src/lib.rs#L357

Why do you want it changed?

SamWilsn avatar Dec 17 '22 02:12 SamWilsn

See the following:

https://github.com/ethereum/EIPs/blob/8177797903d4ce8b7a361687baaad0356538e83d/EIPS/eip-725.md#L24

Pandapip1 avatar Dec 17 '22 02:12 Pandapip1

Those should've been changed to ERC725X and ERC725Y to refer to the interfaces, in my opinion. I'm not a huge fan of the EIP-9999G format since anyone can create one and we have no mechanism for preventing conflicting names.

SamWilsn avatar Dec 17 '22 02:12 SamWilsn

Not necessarily true - the EIP itself defined those names in this case.

Pandapip1 avatar Dec 17 '22 02:12 Pandapip1

Very true!

SamWilsn avatar Dec 17 '22 02:12 SamWilsn