Sam Wilson

Results 309 comments of Sam Wilson

> What about htmlproofer and codespell? Codespell was not enforced for a long time, so there are at least 6 EIPs that have codespell errors. Not sure what to do...

My biggest issue, and the one preventing the merge of this proposal, is that I still do not believe that this proposal has sufficient detail for a third party to...

I'm pretty sure this one is still active.

> I still would like confirmation that footnotes work. How's this: https://samwilsn.github.io/EIPs/EIPS/eip-1

> Is there anything wrong with this PR? Nope, normally these automerge, but not this time around.

Yeah, I think we could give the bot permission to push straight to `master` without a PR. Not sure if we want to go that route though. Unless someone changed...

![Screenshot 2022-11-18 at 12-44-23 Branch protection rule](https://user-images.githubusercontent.com/57262657/202768778-8bfbdb24-70fe-4a35-b660-abc3a63ee406.png)

There's still a few outstanding comments. Most importantly about the Rationale section.

I am not qualified to comment on reverting in a precompile (though I can't see why it would be a problem.) That said, it might be best to format the...

I *think* my preference for this would be to remove the links entirely. I don't want to establish a precedent of updating broken links in old EIPs. Should probably be...