Sam Wilson
Sam Wilson
Not stale, just waiting on author review.
I'd like to leave some feedback on the bot itself before we make the switch, but besides that, I have no problem with this!
I have left some feedback on eip-review-bot. Code is very understandable! My only concern is that there aren't any automated tests that I could see. Personally I'd like to see...
I believe my concerns regarding automated testing have _mostly_ been resolved. I am still nervous about switching to a new merge guardian, and would _like_ to see some tests that...
Just FYI, this'll need to wait for 7620 to get into Review before it can merge.
It looks like the implementation of Falcon is MIT licensed: https://github.com/PQClean/PQClean/blob/master/crypto_sign/falcon-512/clean/LICENSE You could copy that directory into `../assets/eip-7619/` and link to it from your proposal.
> are there any issues you came across in production that's touching on this code? Here's an example: https://github.com/wallet-test-framework/glue-ws/blob/0322225d8979f2d3995efb1d703d98c6f672f75d/src/index.ts#L68-L70 I have to disable the [`@typescript-eslint/no-misused-promises`](https://typescript-eslint.io/rules/no-misused-promises/) lint because the function doesn't...
This is so cool! Really love it :two_hearts: Does it require and active backend, or can we push it to GitHub Pages? Is ETK compiled to WASM?
Looks like this has popped up again.
Following academic citation guidelines (so we're indexed in Google Scholar) is actually a pretty decent reason on its own to support adding `finalized`.