EIPs icon indicating copy to clipboard operation
EIPs copied to clipboard

Automerge bot needs Administrator permissions

Open Pandapip1 opened this issue 3 years ago • 1 comments

Pull Request

No response

What happened?

@eth-bot needs admin permissions to bypass CI checks for "move to stagnant" PRs.

Relevant log output

I reran the stale bot recently, and due to a separate bug it didn't try to merge the PR it was continually trying to merge. So 3 months worth of stagnant PRs were opened.

Pandapip1 avatar Nov 15 '22 15:11 Pandapip1

@SamWilsn would you mind fixing?

Pandapip1 avatar Nov 16 '22 14:11 Pandapip1

~~Actually, I found https://github.blog/changelog/2021-11-19-allow-bypassing-required-pull-requests/. Is this possible to do with our current GitHub plan?~~

Never mind, this deals with pushing without making a PR and wouldn't work.

Pandapip1 avatar Nov 18 '22 17:11 Pandapip1

Yeah, I think we could give the bot permission to push straight to master without a PR. Not sure if we want to go that route though.

Unless someone changed it recently, it looks like the bot already had admin:

image

SamWilsn avatar Nov 18 '22 17:11 SamWilsn

Screenshot 2022-11-18 at 12-44-23 Branch protection rule

SamWilsn avatar Nov 18 '22 17:11 SamWilsn

Huh, weird. Must be some other bug. I'll look into it.

Pandapip1 avatar Nov 18 '22 22:11 Pandapip1