EIPs icon indicating copy to clipboard operation
EIPs copied to clipboard

Add EIP-5883: Token Transfer by Social Recovery

Open wsdt opened this issue 3 years ago • 6 comments
trafficstars

title: Token Transfer by Social Recovery

description: This EIP describes a token recovery by a transfer from an identity which is not accessible anymore to another newly created identity by social interaction.

Looking forward to feedback!

wsdt avatar Nov 06 '22 10:11 wsdt

All reviewers have approved. Auto merging...

eth-bot avatar Nov 06 '22 10:11 eth-bot

I couldn't see where an EIP editor assigned the EIP 5807? I assume this EIP should be EIP5882 as that was the original PR (unclear why #5882 was closed)

abcoathup avatar Nov 07 '22 23:11 abcoathup

Does anybody know why the HTMLProofer fails, receiving this error

Liquid Exception: Liquid syntax error (line 33): Variable '{{{\displaystyle\sum_{i = 1}' was not properly terminated with regexp: /\}\}/ in EIPS/eip-5883.md

That would be in the middle of the code snippet.

wsdt avatar Nov 09 '22 09:11 wsdt

We checked the markdown linter issues for now. The html proofer seems to be wrong.

mrqc avatar Nov 13 '22 15:11 mrqc

HTMLproofer is not wrong. Make sure that you escape any {{ or }}.

Pandapip1 avatar Nov 16 '22 14:11 Pandapip1

Should be fine now, thanks everyone!

[@axic, @SamWilsn, @Pandapip1]

wsdt avatar Nov 16 '22 15:11 wsdt

When does the eth-bot review the PR? Is there something else to be done? Thank you in advance!

[@axic, @SamWilsn, @Pandapip1, @eth-bot ]

wsdt avatar Nov 25 '22 14:11 wsdt

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

github-actions[bot] avatar Jan 11 '23 00:01 github-actions[bot]

Ping - any chance to get this to Draft? Are we missing something?

wsdt avatar Jan 11 '23 07:01 wsdt

There's still a few outstanding comments. Most importantly about the Rationale section.

SamWilsn avatar Jan 31 '23 01:01 SamWilsn

Fixed, sorry overlooked them! Thanks @SamWilsn

wsdt avatar Jan 31 '23 10:01 wsdt

@eth-bot

wsdt avatar Feb 05 '23 21:02 wsdt

anything missing? Would appreciate an update, thank you :-)

wsdt avatar Feb 15 '23 17:02 wsdt