Hyunjin Song
Hyunjin Song
Should we fix factory files in `stable-1.2`, or `master`?
In the checklist, first two things can be fixed easily. I can create a pull request addressing them.
I think I might be going to fix this later.
True. That's why I said that's a temporary patch.
BTW, Is it still worth supporting Windows VST on macOS?
See also: #5104
Possibly related: https://gitlab.freedesktop.org/xorg/lib/libx11/-/merge_requests/57
Playing a sample or instrument with LS Filter's cutoff frequency near max mutes the project's audio.
How can I reproduce that? Could you please provide steps to reproduce?
Playing a sample or instrument with LS Filter's cutoff frequency near max mutes the project's audio.
@Sawuare I just reproduced that right before you post the comment. :smile:
Playing a sample or instrument with LS Filter's cutoff frequency near max mutes the project's audio.
https://github.com/LMMS/lmms/blob/68c85c8e0579827994759573698c5b27f9c71832/plugins/LadspaEffect/swh/util/biquad.h#L105-L118 Here `alpha` blows up for high frequencies, because `omega` approaches to π and `sn` to `0`. Here `a2` is set to `NaN` since it is zero times infinity. Possible...