Instrument presets saves MIDI settings

[zonkmachine]

Instruments are saved with MIDI settings as is the case with some of our factory presets. When previewing these sounds the project is set to modified. Saving instrument presets should not save any MIDI information. Examples: Monstro - Growl, HorrorLead

• [x] Fix factory presets. (#4207)
• [x] Check factory projects. (#4207)
• [ ] Don't save MIDI settings.

Related: Presets remember the controller connections

[qnebra]

Maybe this section is preset? Taken from Monstro - Growl preset:

</midiport inputcontroller="0" inports="" fixedoutputvelocity="-1" inputchannel="0" outputcontroller="0" writable="0" outputchannel="1" fixedinputvelocity="-1" fixedoutputnote="-1" outputprogram="1" basevelocity="63" readable="1"/>

Of course without this / on beginning.

[PhysSong]

Fix factory presets. Check factory projects.

I've ran git grep readable=\"1\" | awk '{ print $1 }' | awk -F ':' '{ print $1 }'. Here's the list of problematic files got with this command:

data/presets/LB302/DroneArp.xpf
data/presets/Monstro/Growl.xpf
data/presets/Monstro/HorrorLead.xpf
data/presets/TripleOscillator/Erazzor.xpf
data/presets/TripleOscillator/GhostBoy.xpf
data/presets/TripleOscillator/SEGuitar.xpf
data/presets/TripleOscillator/Supernova.xpf
data/presets/TripleOscillator/TINTNpad.xpf
data/presets/Watsyn/Pulse.xpf
data/projects/demos/StrictProduction-DearJonDoe.mmp
data/projects/shorties/Crunk(Demo).mmp
data/projects/templates/AcousticDrumset.mpt
data/projects/templates/CR8000.mpt
data/projects/templates/ClubMix.mpt
data/projects/templates/Empty.mpt
data/projects/templates/TR808.mpt
data/projects/tutorials/editing_note_volumes.mmp

And we may fix that using sed.

[PhysSong]

Should we fix factory files in stable-1.2, or master?

[zonkmachine]

I think stable-1.2

[tresf]

Yes, stable. 1.3.0 is slated to use the assets repo instead.

[PhysSong]

In the checklist, first two things can be fixed easily. I can create a pull request addressing them.

[zonkmachine]

In the checklist, first two things can be fixed easily. I can create a pull request addressing them.

Yes. Fix the first two for 1.2 and the saving issue some other time.

[zonkmachine]

Possibly related to https://github.com/LMMS/lmms/issues/1644

[Rossmaxx]

How hard is it to get this done? I might handle this. Need some pointers to look at tho.