Hyunjin Song
Hyunjin Song
I found that the feature is confusing for many people, and the confusion results in bug reports. Thus, I'd like to either remove or deprecate this feature. My plan consists...
@JohannesLorenz Why do you marked this for 1.2? Shouldn't we take care of compatibility issues? > `static` in a header function does make no sense Not always, see this: https://gist.github.com/htfy96/50308afc11678d2e3766a36aa60d5f75
I think we may implement a 'power' scale(`x^a`) and upgrade the existing *weird-and-fake logscale* to it. In this way, we can support the old behavior while adding the correct behavior...
This pull request now have massive merge conflicts due to #5712 and class renames. I will try to resolve them after refactor.
I think I should wait for #5924, which is very likely to contain a lot of duplicated works.
> I believe this can be resurrected Yes, I just don't have enough time for now(until the end of this month).
I'll possibly redo the work because of the large changes in the codebase.
Why you didn't implement loading/saving `m_outputGain`?
I can reproduce this for drag&drop. The steps are: 1. Drop a Zyn preset on the song editor. 2. Drop another preset(ex. `TripleOscillator/Arpeggio.xpf`). 3. Drop the preset in step 1...
> Fix factory presets. Check factory projects. I've ran `git grep readable=\"1\" | awk '{ print $1 }' | awk -F ':' '{ print $1 }'`. Here's the list of...