Patrick LaFontaine

Results 156 comments of Patrick LaFontaine

I was also wondering if you were interested in generating additional parts of the documentation example? The following appears at first glance to be rather standard and shouldn't be that...

If one was going down this route, I think I would switch from using type aliasing of the `HConsed` and instead use https://doc.rust-lang.org/rust-by-example/generics/new_types.html . Then maybe you could derive something...

> I see that you do require the top-level hashconsed type to be a newtype. That's fine, but I think it's important it `Deref`s to the hashconsed value so that...

> And since we need more than one crate to write the proc-macro, we should probably package the hashconsing crate itself in a `hashconsing` folder and have a top-level `Cargo.toml`...

> Also, `impls` really does two things at once: generate a static factory, and generate the constructors. > > I would split it in `factory` and `constructors`, with `factory =...

Hello, Sorry if I let this slip through. If you find time at some point, I am still interested in addressing concerns and completing this pr.

> I can't see any examples, could you add some to facilitate the discussion? Maybe the best way is via writing the doc tests so those get iterated on at...

Hello! I was wondering about this kind of functionality and came across this pr. I'm curious about it's status? I'm sure it would be super useful for projects with larger...

Thanks for continuing to work on this feature, I'm interested in it getting merged(and @dburgener for keeping up with the reviewing here)! This didn't seem like a breaking change to...

(I'm hopeful that most of my review comments are higher level and easy to address so we don't need too much more time to get this through)