Patrick LaFontaine
Patrick LaFontaine
I'm using this pr in my own project to get more of a hands on feel. One thing I've noticed is that it's probably pretty free to add attributes to...
An extension for a future pr might be to allow cfg attributes in more parts of the grammar. For example, I wonder if the following would be eventually possible(since it...
I've tried this pr out with my own use-case and besides the ergonomic suggestions I have made, it seems to work as expected. https://github.com/Pat-Lafon/bril/commit/834dbd0aa8e120f9b41c1fc52d401149ad443d8d
> It would be great to support attributes on nonterminal productions! > > I also needed them on the explicit terminals, which I already implemented already [here](https://github.com/k2d222/lalrpop/tree/more-cfg-attributes) and used in...
Thanks @yannham for the answer, I think I will close this issue now.
Thanks for the pr! It looks like this could use a quick `cargo fmt`. I think this also addresses #706?
Before I go wrongly closing a bunch of issues, I'll just list them here in case I'm mistaken(or if anyone sees those issues since this pr might help them solve...
#906 and #902 will make it in. Is it accurate to say that https://github.com/lalrpop/lalrpop/blob/master/publish.sh doesn't get used anymore?
> Just pinging on this. I'm assuming the reason we're waiting is clarifying the process in #914? > > Given a lack of additional comments there, it seems to me...
I looked through the history since July 10th and added two more items to the changelog. I looked at `cargo-release`. It seems their workspace flag also tries to release the...