Patrick LaFontaine

Results 156 comments of Patrick LaFontaine

How does one write this program? I'm not super familiar with threads so more for my own benefit. So I think almost all of the major structures in the z3...

What about converting `from_i64` to accept anything that satisfies `Into`? Would that still work but also support more integer types?

Hmmm, this is doable except that there needs to have extra handling for the impl's because `Into` will also work `u64` which is currently implemented separately and uses `Z3_mk_unsigned_int64` instead....

> Maybe there's room here to use `num` or `num-traits`? Sort of? So `num_traits::Signed`/`Unsigned` is what we want here, but my attempt currently doesn't work because (I think) we haven't...

Oh, hmm, I see that there are ci issues because of rayon's dependencies having build scripts(outside of the two non-deterministically failing tests I had mentioned). I don't think there is...

@m-esposito I rebased on main and took your suggestion for `&Arc` -> `Arc` though it seems to run afoul with clippy. Do you think it is a false positive with...

I would be interested in seeing this as a pr, even if just to add this to my own fork. Do you have a benchmark you can add to the...

And just randomly, I'm wondering if you have any thoughts on updating the edition to 2021? Sorry if you've already considered this.

Sure, I would be interested in attempting it.

> For the `derive` macro, I would expect it to look like this: > > ```rust > #[derive(HConsed(RawTerm), Debug, Hash, Clone, PartialEq, Eq)] > enum Term { > Var(usize), >...