Patrick LaFontaine
Patrick LaFontaine
> No it makes no change. I'm trying to make it consistent with other tuples. Ok, sounds reasonable to me. I think it's worth elevating for @dburgener that there is...
> Note that LALRPOP's tuple parameters must have at least two elements. Well this comment was added in the recent commit, so it sounds like unary tuples are no longer...
@lalrpop/maintainers Looking for a review and also noting that I don't seem to have write access despite being a lalrpop member... that's fine but hopefully someone active does for when...
Will close #4 and a pre-req for https://github.com/lalrpop/lalrpop/issues/856
The original set of tests don't take into account style/color. I've poked at this enough so that I can write some expect-tests for the current behavior when it comes to...
Just passing by but this looks unrelated to the linked issue. I'm imagining that brilc isn't taking into account that some of your variables are constant and don't need phi...
To restate some of an off github conversation, Bril to LLVM compilers have this edge case with phi nodes because the Bril currently imposes very few constraints on their usage...
This is very cool! I'm interested in getting this merged. I've ran the pipeline so that you are aware of a the minor lints clippy reports. Having some tests would...
> > Does this mean users need to enable features at lalrpop build time and not when trying to compile/run with their generated grammar? Do we rebuild the grammar if...
@k2d222 I've done some of the straightforward work to help this pr along. - It's now rebased on master after the version bump - Addressed clippy lints - Fleshed out...