Patrick LaFontaine
Patrick LaFontaine
Sorry for all the comments, hopefully some of them were helpful but otherwise take them all with a grain of salt. Your team thought about this a lot more than...
The `brilirs` version is consistent with the `Wrapping` type in Rust. https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=24433b06279415b718abed7a1ae3ad55 I would guess `brili` is doing the multiplication with a larger integer format and then truncating down to...
Try printing out x then to see if the value is different. Might also be interesting to print out val here before it gets converted to bigInt https://github.com/sampsyo/bril/blob/daaff284fdaee0319ab8cdcdaa9c620606125889/brili.ts#L466
This is maybe a step towards #766
> Don't you need to pass a Lexer to parse(), rather than a Token? Ah, whoops. Thanks. I've made your change and then cleaned things up. It now runs as...
> I started briefly poking at this. Part of the challenge here is that our usage of term is also tied into our ASCII canvas dependency (https://github.com/nikomatsakis/ascii-canvas). Ascii canvas is...
This conversation reminded me of http://moscova.inria.fr/~fpottier/menhir/manual.pdf#section.11. There has been some cool work on menhir which I think addresses this issue. Maybe there is a simplified version of what they do...
At a quick glance, is this related to #768?
Ah whoops, I see you just commented on that issue. Race-conditions...
Is this related to https://github.com/lalrpop/lalrpop/issues/391? Note the comment with the minimized grammar https://github.com/lalrpop/lalrpop/issues/391#issuecomment-778940697