Pieter-Jan Briers

Results 273 comments of Pieter-Jan Briers

This should really check if the control is possibly involved in a child selector, and only do the recalculation in that case.

This has begun with 3246ad2d92da432357c8f1723053df5af84ddab3 and 788e9386fd06edddca8a0c2f53accee7cd116331

These keys are not exclusively used by SpriteComponent. It seems like we should have a solution that covers other solutions too?

> Any way I can help with this? It's been sitting for quite a while now. You can make a new PR that supersedes this one.

> you forgot to implement the interface for `public Dictionary EdgeSpaceSprites` in [ContentTileDefinition.cs](https://github.com/space-wizards/space-station-14/blob/master/Content.Shared/Maps/ContentTileDefinition.cs#L119) Please do not come into this repo with comments like this if you have no idea how...

> Really that path? I would have expected something more like `/run/user/1000/kio-fuse-something`, replacing 1000 by your numeric user ID (the output of the command `id -u`). They typo'd, it is...

> What specific mechanism is this game using to have "file picker support"? Do you know what APIs it is calling into? We're currently using SDL3's new filesystem picker API,...

> I think our file picker works via SDL3, if im correct this is the code responsible in our engine https://github.com/space-wizards/RobustToolbox/blob/f75ce13f007550f3dca725b5061d6f2a863f7426/Robust.Client/UserInterface/FileDialogManager.cs#L21 That code's mostly the only nfd/kdialog backends, the actual...

What is the use case for this? This kind of feels like a high-level helper function and I'm not sure it's appropriate to have in engine.

We need a proper render graph architecture or something like that instead.