Pieter-Jan Briers

Results 273 comments of Pieter-Jan Briers

I'm updating our dependencies as part of the .NET 10 upgrade and newer versions of the Roslyn packages cause an analyzer error for usage of `ISourceGenerator`. It can still be...

> is there a reason not to be able to choose your localization-option on client-side? With the current localization system it is (practically) impossible to do this, as the server...

Wrote more about what this would take to implement here: https://forum.spacestation14.com/t/separate-client-server-localization-i-e-ftext/22795

> This makes it very annoying to get the types parsed by the previous parsers inside a `CustomTypeParser` (you would need to manually call Evaluate with a Invocation Context, very...

> One of the arguments requires filtering based on a previously given argument. This filtering should surely be performed by the *command*, not the parser, no?

> This is for the sake of autocomplete. In the PR, your `TryParse` implementation totally uses this too, though? Anyways, I asked Kaylie and she said there's various issues in...

> Well yes, because it makes sense. TryParse uses the same logic to verify No, it does not. What if your parser doesn't run at all, because a variable is...

> But in any case, I would still want advise on how else you would achieve this behavior. For autocomplete that is. > Anyways, I asked Kaylie and she said...

Thanks for the investigation on this issue from both you and @eoineoineoin. Sorry for not reviewing it sooner. I do prefer this fix. Layout loops happening across frames (but only...

Remove static IoC in general, what could go wrong?