Pieter-Jan Briers

Results 273 comments of Pieter-Jan Briers

> As I've mentioned before, I'm pretty new to C#, but a cursory look at [the happy eyeballs implementation in robust toolbox](https://github.com/space-wizards/RobustToolbox/blob/master/Robust.Shared/Network/HappyEyeballsHttp.cs#L42) tells me I should be able to do...

So... what's the point of this?

Closing given lack of response.

So I don't mind having this as a feature (assuming you change the API so the request takes a proper cancellation opportunity), but this PR isn't necessary to implement your...

Aesthetically I definitely prefer having the separators between columns. Also the "go to servers tab" button being full-width is weird.

You can't a server info entry after opening it. Also removal of the arrow indicating it's expandable is bad UX.

This should not be a black list for fuck's sake. The whole problem with the original PR was that we "can't foresee what might break in the future".

> If you are adding a new species you have hopefully tested it with Nukies (and thus added it to the blacklist if necessary). Literally the whole reason there is...

Ok wait I'm taking a look at this and the reason this is broken is different than I thought.

So this is fucking stupid. The solution *is* in fact configured to use the correct configuration when building for Tools: ![image](https://github.com/space-wizards/RobustToolbox/assets/8107459/0d9c40e0-1e2b-4f86-ad42-bd4a86a0cc97) The problem is that compiling the project directly with...