RobustToolbox icon indicating copy to clipboard operation
RobustToolbox copied to clipboard

tile space edges rendering

Open TheShuEd opened this issue 1 month ago • 6 comments

requires: https://github.com/space-wizards/space-station-14/pull/41216

A new field has been added to ITileDefinition: EdgeSpaceSprites image

If a tile touches space, it will use different edge sprites than when it touches other tiles.

Why is this necessary?

When developing the z-level system, using regular edgesprites at the boundary with air is not aesthetically pleasing. It would be desirable to have the ability to render a separate view of the tile edges in this situation.

image image

TheShuEd avatar Oct 31 '25 10:10 TheShuEd

idk how to connect PR to content PR, for unit test fixing

TheShuEd avatar Oct 31 '25 11:10 TheShuEd

you forgot to implement the interface for public Dictionary<Direction, ResPath> EdgeSpaceSprites in ContentTileDefinition.cs

kin98 avatar Nov 13 '25 14:11 kin98

you forgot to implement the interface for public Dictionary<Direction, ResPath> EdgeSpaceSprites in ContentTileDefinition.cs

https://github.com/space-wizards/space-station-14/pull/41216

TheShuEd avatar Nov 13 '25 14:11 TheShuEd

the test failed becouse of the ContentTileDefinition.cs doesnt implement the https://github.com/space-wizards/RobustToolbox/blob/5ea9c722172bffa51af9e8e651e3442c4e2b7a33/Robust.Shared/Map/ITileDefinition.cs#L11

kin98 avatar Nov 13 '25 14:11 kin98

the test failed becouse of the ContentTileDefinition.cs doesnt implement the

https://github.com/space-wizards/RobustToolbox/blob/5ea9c722172bffa51af9e8e651e3442c4e2b7a33/Robust.Shared/Map/ITileDefinition.cs#L11

nvm theres a sepreate pr for content that is needed

kin98 avatar Nov 13 '25 14:11 kin98

you forgot to implement the interface for public Dictionary<Direction, ResPath> EdgeSpaceSprites in ContentTileDefinition.cs

Please do not come into this repo with comments like this if you have no idea how engine development usually works.

PJB3005 avatar Nov 13 '25 18:11 PJB3005