Zixuan Li

Results 238 comments of Zixuan Li

Thanks! Updated the PR.

Got that test back. Thanks for the review!

Thanks for the review! Added some TODOs commits for `GetServerSettingsResult` changes, making them easy to drop, and addressed the issues from the review. This revision should be fairly readable with...

Yeah. I think this mainly needs an update resolving the TODOs/new comments and a reread. I can get back to this tomorrow night (don't have my laptop with me today)....

Pushed an update addressing the new TODOs and the comments above.

Thanks for working on this @chimnayajith! I took a quick look at the implementation and checked the design. There are places where it currently does not match the Figma, for...

Hi @chimnayajith! Thanks for working on this. Since this issue is a launch blocker, we would prioritize reviewing this/getting this done first; the other issue that you are working on...

I think we shouldn't need to add a snack bar/dialog, since the error should have been handled from the polling loop in `UpdateMachine`. Such an error might look like this:...

Looks good! Just one small comment.