Zixuan Li

icon indicating a website link https://pig208.itch.io/

icon location New York City

Results 238 comments of Zixuan Li

Compose box redesign

Thanks for the review! I have updated the PR.

Compose box redesign

Thanks! Updated the PR.

Compose box redesign

Moved the links to the paragraph they each correspond to, and added the comment on `ClipRect` (the related paragraph is still kept in the commit, in case the reader is...

Enable unawaited_futures

TODO: `TestGlobalStore`'s `doInsertAccount` implementation has a race condition for checking the invariants. Concurrently adding accounts allows you to bypass the check.

Enable unawaited_futures

This is stacked on top of #937.

Enable unawaited_futures

This is stacked on top of #970 ([`dialog [nfc]: Wrap showErrorDialog's return value`](https://github.com/zulip/zulip-flutter/pull/970/files)). The PR is mostly small commits for refactors in a limited scope.

Enable unawaited_futures

Updated the PR by cherry picking #970 and #985 and cleaning up some commit messages. (The CI failure comes from #985)

Enable unawaited_futures

I think we should keep #731 open because there is still some chance that we can use that rule, but not in the near future. Mentioning it in the commit...

Enable unawaited_futures

Thanks for the review! Updated the PR and fixed some more errors that appeared after rebasing (and applied #731)

Start Requiring Zulip Server 5

The PR itself is ready, but we won't be ready to merge it until we refuse to connect to older servers. Going through some reviews will still be helpful, though.