zulip-flutter icon indicating copy to clipboard operation
zulip-flutter copied to clipboard
verified publisher icon zulip

actions test: Await all responses; cut pumpAndSettle

Open gnprice opened this issue 1 year ago • 1 comments

This ensures that if one of these markNarrowAsRead calls were to change behavior so that it no longer completed within the test (and then possibly threw an error, or failed to ever complete at all), the test would catch that.

Prompted by this thread: https://github.com/zulip/zulip-flutter/pull/934#discussion_r1796319431

gnprice avatar Oct 11 '24 01:10 gnprice

Looks good! Just one small comment.

PIG208 avatar Oct 11 '24 02:10 PIG208

Thanks for the review! Merging with that tweak.

gnprice avatar Oct 12 '24 00:10 gnprice