Bruce Ritchie
Bruce Ritchie
> I think making physical-exprs depend on datafusion-functions would be unfortunate (as it would still mean there could be dependencies / special cases from built in functions to "built in"...
Not sure what to do about references to to_timestamp function in test code such as - core/tests/parquet/row_group_pruning.rs - core/tests/parquet/page_pruning.rs - optimizer/simplify_expressions/simplify_exprs.rs This seems mostly to be in tests however I'm...
Thanks @alamb, I'll look at moving those tests out to the core/tests/ area.
I haven't had time to look it over yet but first thing I did see was the use of Date64 - I can't see any good reason to use that...
> Date64 contains more number in my opinion. Maybe Date32 is better? ``` /// A signed 32-bit date representing the elapsed time since UNIX epoch (1970-01-01) /// in days (32...
@Tangruilin - Do you think you'll have time to complete this PR before v36 is released?
> @Omega359 The `cargo test --doc` command is passed on my mac. But the CI fail. I do not know why I think it's because you are attempting to include...
#7 is my preference.