Bruce Ritchie

Results 70 comments of Bruce Ritchie

Add make_time function

More info: the only way I could get `rust fmt` to output the use statements in the same order as ci was to force the datafusion-functions crate to use the...

The config values aren't checked

The timezone config option would be another to add validation to.

Reduce cloning in LogicalPlanBuilder

Can we get a run of the planning benchmark compared to main to see if this has any affect on performance?

Reduce cloning in LogicalPlanBuilder

Seems like this PR is resulting in a perf slowdown

Migrate documentation for remaining window functions to window_functions.md

Would it be possible to add documentation for lead/lag prior to waiting for all the remaining window functions to be migrated over?

Migrate documentation for `regr*` aggregate functions to code

Beyond the one minor change this LGTM

[EPIC] Automatically generate all function content from code

FYI I've finished up the string expression migration locally - just waiting on the updated code from #12742 to land before pushing a PR.

[EPIC] Automatically generate all function content from code

No rush I just wanted to make sure no one was duplicating work needlessly

[EPIC] Automatically generate all function content from code

lead/lag PR @ https://github.com/apache/datafusion/pull/13095 Other functions that still exist on scalar functions page - https://github.com/apache/datafusion/issues/13036

`generate_series` doesn't respect memory limit

I actually recall thinking about that a bit when I was adding sub-day support to generate_series. Thanks for filing this issue