Bruce Ritchie

Results 70 comments of Bruce Ritchie

WIP: Generate docs from macros.

> @Omega359 is it good to have a `documentation` method on struct level instead of impl? I can't think of a reason why not off the top of my head....

WIP: Generate docs from macros.

> Let's wait to see what @Omega359 has to say too, but I would be inclined to merge it in (as it is an optional feature) once we have a...

WIP: Generate docs from macros.

Sorry, I've been busy lately. I'm hoping to get to reviewing this PR this week

WIP: Generate docs from macros.

I'm fine with that @comphead - we can file followup issues to add the alternative syntax, etc

Fix: Internal error in regexp_replace() for some StringView input

There are a few things I noted when I reviewed this pull request, some of which may be good to either fix here or in other tickets/PRs: - The return...

Fix: Internal error in regexp_replace() for some StringView input

> Could you please elaborate more on the return types in the first bullet? Sure. That was one I saw that wasn't related to anything in this PR but that...

Fix: Internal error in regexp_replace() for some StringView input

Note that the above comment could (should?) be another PR - it was just noted by me when looking at the code for this.

`octet_length()` function not working for StringView columns (SQLancer)

take

`octet_length()` function not working for StringView columns (SQLancer)

This issue will be fixed once the arrow_string dependency is updated.

`octet_length()` function not working for StringView columns (SQLancer)

Array-string dependency was updated to 53.1.0 which includes the update from apache/arrow-rs#6305. I'll work on a PR to verify the fix in octet_length()