Bruce Ritchie

Results 70 comments of Bruce Ritchie

> Related to this, `substring` in Postgres supports regex matching (see https://www.postgresql.org/docs/current/functions-matching.html), would it be reasonable for DataFusion to also support it? > Postgres's regex substring takes a string, a...

> It is a good idea to support these functions, especially for `regexp_matches`, Thank you. Adding `regexp_matches` would be trivial - it's essentially the current `regexp_match` but the 'g' (global)...

> Related to this, `substring` in Postgres supports regex matching (see https://www.postgresql.org/docs/current/functions-matching.html), would it be reasonable for DataFusion to also support it? > > The currently accepted argument types are:...

> I can implement [regexp_substr()](https://pgpedia.info/r/regexp_substr.html) can I just create a pull request or do I need to be added to some access list? A PR should be fine. You should...

Just a few things that come to mind: Functions: - New: nv1, nvl2 - Improvements: unnest, null handling improvements for lead/lag

If I find time this month I may work on this as it would be a nice feature to have.

Well that is unfortunate. I wonder if the apache regex is correct - the one in the error message is not, should be `.*\/.*@[a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9][a-f0-9]+`

I think a committer should bring this up with apache infra structure folks as I cannot see a way to follow the directions in the apache github actions policy here...

This seems like it may almost be an alias for [nvl](https://datafusion.apache.org/user-guide/sql/scalar_functions_new.html#nvl) or [nvl2](https://datafusion.apache.org/user-guide/sql/scalar_functions_new.html#nvl2)

> In my mind I/O in functions is the usecase. > > Flexibility in APIs is good, but I don't feel like we have a good sense of other problem...