nora

Results 207 comments of nora

can we change it to a bash shebang instead? the bash looks less bad than the posix shell. I don't think it matters which shebang you choose exactly because I...

@rustbot author waiting for you to address the feedback and just change the shebang

better idea: just rewrite the test in rust instead: #121876

I cannot reproduce the original anymore, but #121357 does reproduce. The body is impossible because of the where clauses, so no MIR opts should ever run on it... I'll take...

The bisection here isn't useful sadly, but thank you anyways. I took a look and yeah, the issue is what I suspected. `impossible_predicates` (https://github.com/rust-lang/rust/blob/bb594538fc6e84213a6b8d5e165442570aa48923/compiler/rustc_mir_transform/src/lib.rs#L451) checks whether there are any impossible...

There was some confusion with regards to why `--no-allow-shlib-undefined` is passed at all. From a bit of experimentation it looks like both binutils `ld` and `ld.lld` do this by default....

Going to merge this, as it seems useful enough. We can always change the style later.

no, I was just playing around so I didn't need one

I don't think the `Relaxed` ordering is correct here. The check could be reordered to after the construction or even later after the arena is used, causing two arenas to...

Oops, that's what I get for throwing something up quickly before going to bed. Will fix (or someone else can fix it for me if you want to :D).