nora

Results 207 comments of nora

Hi, I've seen you changed some diagnostic structs in your PR. After #103345, the way we refer to fluent messages changed. They are now in a flat namespace with the...

This is probably a leftover from the time when `if let` used to desugar to a `match`, which keeps the scrutinee temporaries alive until the end of the match. Dropping...

I don't see why an old issue shouldn't be around. Just because it's old doesn't mean that it doesn't matter or that it's not a real issue. The visibility problem...

Hi, I've seen you changed some diagnostic structs in your PR. After #103345, the way we refer to fluent messages changed. They are now in a flat namespace with the...

Could you use `perf top` (if you're on linux) or something similar to find out where rustc is spending all of its time? Alternatively, building rustc yourself and then using...

If this function is where it spent its time hanging around, then that sounds like an LLVM bug. @rustbot label +A-llvm

Hi, I've seen you changed some diagnostic structs in your PR. After #103345, the way we refer to fluent messages changed. They are now in a flat namespace with the...

If you have to add a completely new method to actually replace these methods, then maybe they aren't ready for removal imo. You should add the new method through the...

> Be extremely cautious about using any function named _untracked from within a query provider. Most rustc code runs inside some form of query provider (for example the entirety of...