rust-clippy icon indicating copy to clipboard operation
rust-clippy copied to clipboard

Handle `rustc_on_unimplemented` in duplicated_attributes

Open Noratrieb opened this issue 4 months ago • 3 comments

#[rustc_on_unimplemented(
    on(
        _Self = "&str",
        label = "`a"
    ),
    on(
        _Self = "alloc::string::String",
        label = "a"
    ),
)]

The lint treats this as a repetition because rustc_on_unimplemented::on::label appears twice, but that's ok.

Fixes #12619

changelog: [duplicated_attributes]: fix handling of rustc_on_unimplemented

Noratrieb avatar Apr 02 '24 19:04 Noratrieb

r? @Jarcho

rustbot has assigned @Jarcho. They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot avatar Apr 02 '24 19:04 rustbot

Oops, that's what I get for throwing something up quickly before going to bed. Will fix (or someone else can fix it for me if you want to :D).

Noratrieb avatar Apr 02 '24 19:04 Noratrieb

:umbrella: The latest upstream changes (presumably #12646) made this pull request unmergeable. Please resolve the merge conflicts.

bors avatar Apr 09 '24 15:04 bors

r? xFrednet

Noratrieb avatar May 09 '24 11:05 Noratrieb