nora
The comment was resolved and @estebank approved it, so @bors r=estebank
The pattern of having an arguments list like that is extremely rare and appears basically never in the standard library documentation: https://github.com/search?q=repo%3Arust-lang%2Frust%20%22%23%20Arguments%22&type=code I don't think the generic "generate documentation stub"...
Yet another unstable codegen flag thrown into the seas of unstable codegen flags... but it seems useful, so let's not block this on figuring out what to do with them...
@apiraino usually closes them after a while But I can do it for you @rustbot label -final-comment-period +major-change-accepted
The rename was approved already. This transition period looks very reasonable, making sure that stable and nightly can be used consistently seems important. @rustbot second
Technical discussion like this should go to the Zulip thread mentioned above.
In the meantime, can we just disable the current checks? Reviewers can complain if a line gets too unwieldy. The current checks make it really annoying to write the documentation,...
I have deleted the checks in #1952, btw.
`ThreadId` uses a `NonZeroU64` as well, keeping the niche
It does have the disadvantage of being a little bigger on 32 bit though.