Morgan Sell comments

Results 79 comments of


Morgan Sell

Create check_y_is_binary() check. Use in transformers in which the dependent variable must be binary.

Yes, the return of the Jedi (DS) Master, @solegalli! ;) Thanks for your feedback! I incorporated the changes and created the appropriate tests. I agree that the user should know...

add function to check that y is binary in dataframe_checks

hola @solegalli, This check will be very useful! I'll work it on. Hopefully, it will be ready for you to review once you return from vacay ;)

add function to check that y is binary in dataframe_checks

Being fixed in #484

OHE: allow encoding of specific, user desired categories

Hi @solegalli, This looks interesting! Are you envisioning that OHE allows the following functionality? - init has a param called `variables_w_new_category` that represents which variables may contain the new category(ies)....

include code coverage

Hola @solegalli, I'm going to git this PR a try. I need to work on my dev skills. This seems like a great place to focus!

include code coverage

Closed by #504.

new discretisation transformer: chimerge

hola @solegalli, I know we still need to finish #454. I'm keen to work on this transformer though! What if I create a PR and layout the initial architecture? Abrazo!

new discretisation transformer: chimerge

fyi #459.

new discretization transformer: IRD or OneRuleDiscretizer

The anticipation is killing me...

feature creation: create new features by combining variables with decision trees

Hola @solegalli, are you still looking for help w/ this issue? I'm happy to tackle this one. A couple of questions: - Is the plan to create a new class...