Morgan Sell

Results 79 comments of Morgan Sell

hola @solegalli, I think I'm heading down a rabbit hole. Before I do, I would like to hear your thoughts. The `init()` performs a few checks to confirm that `output_features`...

hi @solegalli. Ahh.... a month-long vacation! Hopefully, the US will adopt such traditions one day ;) I'm still working on this class. I do have one question. The following test...

Hi @solegalli, I'm embarrassed to say this, but I'm stumped by these errors. Hopefully, we can discuss the errors when you return.

hi @solegalli and @SangamSwadiK, Was this issue completed? I think I saw a PR created and committed for this issue.

@solegalli, I was initially thinking that this class would be similar to ArbitraryDiscretiser where the user passes the desired bins. However, I'm now realizing we may want to incorporate the...

hi @solegalli, With regards to implementation, are you envisioning the following order of operations or something of the sort? - `var_A` is a numeric variable in dataframe `X`. - `fit()`...

hi @solegalli, I'm developing the tests for TargetMeanDiscretiser(). I see that the team has made substantial edits to the unit tests. I'm using the EqualFrequencyDiscretiser and EqualWidthDiscretiser tests as guides....

@solegalli, I'm creating the TargetMeanDiscretiser unit tests. I mentioned in an earlier post that I was using the EqualWidthDiscretiser and EqualFrequencyDiscretiser unit tests as guides. However, I think those unit...

@solegalli, Soy un boludo! I misinterpreted the instructions, which are in the "TargetMeanDiscretiser". Consequently, I created the `_encode_X()` and the rest of the boludese (castellano cientifico). Let me know about...

hola @solegalli, I worked on the documentation (still need to review). I've added the class to multiple `index.rst` files; however, it seems that I'm still missing the table of contents,...