Morgan Sell

Results 79 comments of Morgan Sell

hola @solegalli, I can work on this task. Although, I'm always wary when you write, "It is not so complicated." ;)

Ok, I'm getting back to this issue. I'll get started on it this coming week. @GLevV, a few questions: 1. Are you referring to using x / (x + a)...

Ok, cool. Thanks for the explanation. We're saying the same thing. @solegalli, should we knock out SelectByInformationValue and TargetMeanSelector before jumping into this one? I see it's a priority.

hola @solegalli, I have a couple of question about syntax related to `self` and the use of internal methods: 1. If a method returns a variable that will be assigned...

hi @solegalli, I believe this class is now ready for your virtuoso programming skills ;) I'm confused as to why tests for CountryFrequencyEncoder and OrdnalEncoder are failing. Once you're settled,...

Amazing, @solegalli! How do you see these improvements? Show me the way, Sra Miagi! ;) I'll work on the unit tests. One question, how is `self.performance_drifts_` derived? It's not from...

Hi @solegalli, I'll work on the steps outlined above. Questions/responses to the above comments: 1. I don't think this class requires performance_drifts_ as this attribute is used with shuffled features...

hola @solegalli, I've returned from Black Rock City ;) > why are we deleting PSI selector? Two messages prior, I asked, "Is the drop_psi_features.py the file that needs to be...

hola @solegalli, Are there any additional unit tests that we should create for this class?

Hi @solegalli, Two questions: **Question 1:** Most material that explains information value (IV) has a table that states if IV is greater than 0.5 then the variable's predictive power is...