Morgan Sell
Morgan Sell
Hey everyone, I apologize I forgot to write that PR #488 closes this PR. The PR is mentioned above. I’ve made some decent progress. I’m on vacation. I will continue...
Looks fun, @solegalli! I'm happy to tackle this issue. Which issue do you prefer we address first? This issue or #107?
hola @solegalli, I see sklearn has an experimental version of the [IterativeImputer](https://scikit-learn.org/stable/modules/generated/sklearn.impute.IterativeImputer.htmlrl). Do we still want to implement this transformer into feature-engine? When training the transformer's estimator, will the transformer...
Hi @solegalli, Yeah, I read a paper on MICE. I saw there that R has a MICE package. I'm going to table this one for the moment to focus on...
hola @solegalli, Correct, it's not ready for review. I'm still working on it. And, yes, I'll create tests.
@solegalli, Should we avoid using dataframes and instead use dictionaries and numpy arrays? I suspect iterating through dataframes increases computational costs. I'm going to keep the question, but I think...
hola @solegalli, I think I need an extra set of eyes. I'm struggling to identify what is causing the error for test_chi_merge(). I believe the root cause is in _calc_chi_square();...
hola @solegalli, Did you have a chance to look at this bug? I'm stumped.
hi @solegalli, Are you still getting around to reviewing this discretizer? I think it's super cool! I know you're quite busy. I'm trying to organize myself.
hola @solegalli, Two questions: 1. When we say "binary", are we restricting the values to 0s and 1s? Or, can `y` be a different set of binary variables, e.g. "Y"...