feature_engine icon indicating copy to clipboard operation
feature_engine copied to clipboard

add function to check that y is binary in dataframe_checks

Open solegalli opened this issue 3 years ago • 2 comments

Many transformers in feature engine require that y is binary. At the moment we do this check within each transformer. We should create a function that unifies this behaviour and call it from the transformers instead of repeating all the logic every time.

Example: encoders woe, pratio

solegalli avatar Apr 14 '22 04:04 solegalli

hola @solegalli,

This check will be very useful! I'll work it on. Hopefully, it will be ready for you to review once you return from vacay ;)

Morgan-Sell avatar Jul 09 '22 17:07 Morgan-Sell

Being fixed in #484

Morgan-Sell avatar Jul 19 '22 18:07 Morgan-Sell

Actually, PRatio will be deprecated, so the only transformer atm using binary classifcation exclusively is WoE.

Not worth the effort.

solegalli avatar Aug 18 '22 08:08 solegalli