Morgan Sell

Results 79 comments of Morgan Sell

Yeah, I don't understand why the function cannot look for missing values in all variables. What am I missing?

> Because I think the categorical imputer also uses the base imputer, and then it has a method that is irrelevant. Does this also mean that we cannot introduce `missing_only`...

Hola @solegalli, have you made a decision about this transformer?

@solegalli, Is this as simple as adding `check_is_fitted(self)` to the abovementioned methods?

@solegalli, you had me at "refactoring the way we test." Although, I don't know what's wrong with our current approach. How are you thinking we design our tests?

@solegalli, should this task be closed? It seems like task #403 resolved this issue

@solegalli, resurrecting this issue ;) When someone selects this functionality, do we want to limit the user to one variable? I imagine that the user will select values that are...

@solegalli, I like the idea of using a dictionary. However, I'm unsure if the dictionary should be accepted by `top_categories`. Would it be cleaner to have a separate param called...

hi @solegalli, Were you able to pinpoint the root cause of this issue?