Mingun comments

Results 662 comments of


                                            Mingun

Fix incorrect representation of tuples with skipped fields

> I am not convinced about the last "this should increase performance" commit. Interleaving the skipped and non-skipped fields to construct them in the original source order still seems fine...

Fix incorrect representation of tuples with skipped fields

@dtolnay , all your review comments was resolved, could you look again? I just want to remind you that all changes in the generated code are easy to see if...

Fix incorrect representation of tuples with skipped fields

@dtolnay, yet another gentleman's reminder...

`#[serde(untagged)]` ignores `deserialize_struct` in custom `Deserialize`

My PR #2569 solves the problem with `deserialize_map`

Add checks for conflicts for aliases

@dtolnay, @oli-obk, can you give some feedback?

Deserializing runtime types

> `MyStructRepr` should only be used as a way to drive the deserializer, This looks like `MyStructRepr` is itself should be (part of) deserializer, but I under impression that you...

#[serde(default = "...")] does not work on `flatten`-ed fields.

This is duplicate of #1626

Do not generate unique `__Field` for each struct

Here is some results: [comparison.zip](https://github.com/serde-rs/serde/files/12325396/comparison.zip). Measured commits v1.0.183 (05a5b7e3c6de502d45597cbc083f28bc1d4f4626) and df12e82af225d6de9af8ae54d6a290a380211f31, which removes all possible variants of `__Field` for struct field names and `__Field` for representing variants of externally tagged...

deny_unknown_fields incorrectly fails with flattened untagged enum

This is duplicate of #1358.

Cannot deserialize struct variant using sequence

This would be fixed by serde-rs/serde#2465