Mingun

Results 662 comments of Mingun

You yourself said that many small PRs are better than one large one with a thousand things. It seems to me that it is better to merge this one than...

I think, that `lib/HexLib.jar` anyway won't be updated, so it can be ignored. But if you prefer to not ignore it, I can exclude exactly that jar from ignore list

```java public interface PositionInfo { Map attrStart(); Map attrEnd(); Map arrStart(); Map arrEnd(); } final KaitaiStruct struct = …; // Generator generates classes, that implements this interface, // if debug...

I'll prepare PR in next couple days, where I also plan to change the way information is stored to solve issue #26. I plan to store both positions -- relative...

I agree with @ams-tschoening, that too strict guidlines are not necessary. But I will agree that it looks reasonable to record the bracket placement rules and the size of the...

I implemented `hashCode()`, removed `name()` and fix documentation. Corresponding `equals` is generated in each enum by generator.

@generalmimon, thanks for review! I post some answers with explanation of my minds when I made these changes and if you find they unconvincing, just say and I'll apply your...

Good point! But need to notice, that the such problem exists in the web-ide and maybe in the https://github.com/kaitai-io/kaitai_struct_visualizer. To solve that problem we can track which root `Span` belongs...

Implementation of tags for different stream origins I'll push later. Anyway, it's needed only for correct interpretation of offsets, so maybe even another PR will be preferrable