Mingun
Mingun
I agree that it is better to have a confirmation setting, but picture conveyed are not so terrible. To remove something from the git, you need to purposefully try. The...
Ok, left this for expanding diff view. The two new issues is for settings is linked above this message
Another way to check it is just generate unique docstrings and check presence of them in the generated files. Of course, this will not protect against wrong placed comments, but...
This is because pass [`ParentTypes`](https://github.com/kaitai-io/kaitai_struct_compiler/blob/8aeb79a0069a708bd10cc5b4cc4e3ddf89f58289/shared/src/main/scala/io/kaitai/struct/precompile/ParentTypes.scala) does not process `types` key in KSY. It processes only types, that is accessible from `seq` or `instances` keys, and this is only `type1`. So,...
When fixing this it is also possible to fix #935, their roots are close in code to each other.
Actually, this is duplicate of #89
@generalmimon , while you ideas can be the right in theory, in practice, bugs will be only increasing if no one of existing maintainers will not review and merge PRs...
So what status of this? It is finished or not? If I understand correctly, the only thing remains is to add bunch of features, one for every manual `Serialize` /...
@dtolnay, @oli-obk, it seems that all review comments was addressed here or at least @osiewicz thinks so. Please give your opinion.
I don't know, I am the same external contributor as you. Judging by the general reaction of maintainers, one should hardly expect any attention in the near future