Mingun
Mingun
@dtolnay, @oli-obk, can you give some feedback?
This is indeed a duplicate of #1358
This is duplicate of #1358. `deny_unknown_fields` + `flatten` currently does not work together
It seems that this is a duplicate of #2294 or at least the reasons the same
When `X` is deserialized, it drains external (serde_json) deserializer into internal buffer. Then it creates `FlatMapDeserializer` around it and expects, that all keys will be drained from it during deserialization...
It is hard to say. I never used `skip_serializing_if`. At first glance I think, that we should serialize that as a tuple in all cases. That behavior will also allow...
The problem that right now this changes are coupled and decoupling them requires to replace simple and straightforward code with something more complex. This will be especially noticeable on the...
Yes, that should be possible, just should introduce some checks and possible code duplication. Just to clarify: you don't like changing behavior at all, or `visit_newtype_struct` could be added (it...
- I dropped the last commit that was changing `Tuple2as1` representation. Such structs, however, now supports deserialization using `visit_newtype_struct` method, which technically a side-effect of fixing bug and will allow...
Ok, I removed that commit. I hope compiler will able to reorder operations. > Default objects which are expensive to construct seems like a very uncommon case to begin with...