Michael Hoffmann
Michael Hoffmann
They are but iirc they are truncated ( here https://github.com/thanos-io/promql-engine/blob/662ae7d6e27dac1c18ab4a7deb19add136f51367/engine/distributed.go#L73 )
The engines are created with "zone" external labels but the actual series in them do not have the external label, i think that might be the issue.
As it turns out the engine did not implement or at all. I attempt to add support for it in #318
This looks pretty good to me!
> /assign Just notice that they are currently commented out; but having the target doesnt hurt i suppose!
I wonder: is topk/bottomk even distributable? `bottomk(X, Y)` if X resides on one engine and Y resides on another seems broken, right? We probably only should distribute if the `k`...
Does this testcase make sense? ``` { name: "topk non-distributable", expr: `topk(scalar(X), Y)`, expected: `topk(scalar(X), dedup(remote(Y), remote(Y)))`, }, { name: "topk distributable", expr: `topk(1, Y)`, expected: `topk(1, dedup(remote(topk by (region)...
> Running it in the CI seems like a good idea 👍 hooked it up to the "format" job
I wonder, why does the `enginefuzz_test.go` not generate `NaN` or `Inf` values that seems like it could produce interesting edge cases!
I think this is not well defined because of lookback maybe! You would still need to decode the chunks to check if there is a sample within lookback period