Consistently use reachable commits in tags

[tacerus]

trafficstars

Hello,

I did not find a better place to report an issue with the release process - Thanos itself is great so far.

The packaging system in my favorite distribution relies on Git tags to make automation of updates easier. Upon maintaining the package and attempting to update to version 0.38, I found the update to continue pulling the previous/old version of Thanos.

The following is at the time of writing.

Status of main:

$ git branch
* main
$ git log -n1 --oneline
8f715b0b6b29 (HEAD -> main, origin/main, origin/HEAD) Query: limit LazyRetrieval memory buffer size (#8296)

The latest release tag seems to be v0.38.0:

$ git tag --sort=version:refname |tail -n5
v0.37.1
v0.37.2
v0.38.0
v0.38.0-rc.0
v0.38.0-rc.1

However that one is not recognized by Git, it believes v.0.37.2 to be the latest tag starting off main:

$ git branch
* main
$ git describe
v0.37.2-146-g8f715b0b6b29

(this is where our automation falls through)

The git describe result is presumably due to the commit in v0.38.0

$ git log -n1 --oneline v0.38.0
0439da0dd291 (tag: v0.38.0, origin/release-0.38) Changelog: cut release 0.38 (#8185)

not existing in main:

$ git branch --contains 0439da0dd291
# nothing

Comparing this with v0.37.2:

$ git log -n1 --oneline v0.37.2
18291a78d4c6 (tag: v0.37.2, origin/release-0.37) Merge pull request #7980 from saswatamcode/cut-release-0.37.2
$ git branch --contains 18291a78d4c6
* main

I notice you have release-* branches as well, however checking those out requires prior knowledge about the version number.

I would appreciate if this issue with the current use of Git tags would be considered in the release process.

[MichaHoffmann]

Oh it might be that I forgot to merge back to main when releasing 0.38.0! Sorry for that

[GiedriusS]

I guess it's a task to completely automate the steps in the release process so that this wouldn't happen. I guess that for none of the maintainers this hurts so it's hard to motivate anyone to implement a whole release workflow with no manual steps.

[adharsh277]

Hi @tacerus ! I'm interested in contributing to this issue. Is it still open for first-time contributors? I'd love to work on it.