Results 217 comments of Max Desiatov

I think the logic in `KeyedStorage` looks like the hottest path here, and it's needed to make sure that order of elements is preserved when encoding. Maybe we could could...

>I'm not sure I fully understand. How does this come into play when trying to decode, not encode? I think the most direct way to get exposed to that is...

Yes, that's correct. The elements themselves are stored in a `buffer` that fully preserves the order, but there's also a dictionary that maps from keys to indices in the `buffer`...

That's a great question, thank you for raising this @DJBen. My first guess would be to have a closer look at [`XMLParserDelegate`](https://developer.apple.com/documentation/foundation/xmlparserdelegate) as that's the lowest level API that we...

Hi @MehmetBal, sorry for the delayed reply. Good news is that Foundation's `XMLParser` supports comments. On our side, we only need to find a proper API to integrate it. I'm...

Hi @mxcl, sorry for the delay. Does setting `trimValueWhitespaces` to `false` on `XMLDecoder` instance resolve the issue for you?

I've added a test for this in #137, but it didn't require any changes in the library code, just disabling the `trimValueWhitespaces` flag. Please let me know if anything's missing.

We [trim](https://github.com/MaxDesiatov/XMLCoder/blob/9e680f23e4c06ffee3a7854adc5132ff34ab3ca1/Sources/XMLCoder/Auxiliaries/XMLStackParser.swift#L114) any string chunk that Foundation's `XMLParser` passes us in [its delegate](https://github.com/MaxDesiatov/XMLCoder/blob/9e680f23e4c06ffee3a7854adc5132ff34ab3ca1/Sources/XMLCoder/Auxiliaries/XMLStackParser.swift#L161) function, which usually is just whole XML element content. Oddly enough, `XMLParser` chunks strings on every escaped...

Thanks @bwetherfield, do you have this in a branch to check out? I think I need a closer look to form an opinion.

Reopening this as a reminder to add basic docs for this to `README.md`.