Matan Borenkraout comments

Results 228 comments of


                                            Matan Borenkraout

expose more functions from role-helpers

Thanks for opening this one @kkoo95. The `computeAccessibleName` function is imported from `dom-accessibility-api`, if you want that one, you can npm install and use it. https://github.com/eps1lon/dom-accessibility-api/tree/main

expose more functions from role-helpers

Missed that, sorry. IMO this should also probably be exported from DOM-accessibility-api and shouldn't live in our repo. I currently don't have the capacity to move that functionality there but...

Conflict with symfony's live components

> I think it makes more sense to let users configure the pretty-format options globally. We're going over these again and again and I think there's no good one-size-fits-all. I'd...

Add an MSW example that works with native fetch. (or highlight issues with native fetch)

Thanks @dwjohnston. We're open to any PR that will help clarifying this :)

RTL can't find <fieldset> element and it's children with getByRole

Hi @RikvdSar. This current issue doesn't have enough details for us to try and debug it, also it looks like you wrote `getByRole` but in the example you've used `getByText`....

RTL can't find <fieldset> element and it's children with getByRole

@eianc, if I understand correctly, your issue is different and is related to a change in the ARIA spec. The [spec](https://www.w3.org/TR/html-aria/) dictates that an empty alt will imply role "none"...

Support Node.js fake timers

We also have this one in DTL: https://github.com/testing-library/dom-testing-library/issues/987

lacking documentation for how to run with nodejs built in test runner

Thanks for opening this @soryy708! This is up for grabs if anyone wants to give it a try.

Migration Guide: Testing Playground Chrome Store link is broken

Thanks for reporting this one.. It looks like the extension isn't available in the app store anymore. We'll try to investigate that. @nickserv, @smeijer Does any of you have permissions...

Property 'findByTestId' does not exist on type 'cy & CyEventEmitter' - only in .cy.tsx (component testing) files

I'm transferring this to the cypress-testing-library repo :)