Matan Borenkraout
Matan Borenkraout
Two points here: 1. We do not have the capacity to try and reproduce every issue that's raised in this repo, that's why we ask people who create issues to...
@m-zuro Thanks. In the reproduction you've attached here, the test isn't passing: > ● Test Suite › Test > > Expected value undefined > Received: > undefined > > Message:...
Sorry it took me a while @m-zuro. This error is odd to me, the only place we're calling `document.body.removeChild` is after this if statement: ``` container.parentNode === document.body ``` When...
You can still install `react` and `react-dom` as dev dependencies, this is usually what people are doing in these kind of approaches.
@quisido thanks for taking the time to add this but we are not merging changes without proper coverage for them.
I tried writing a test for this but it passes in our tests because `document.body` is not `null`. I'm trying to figure out what's the difference in the setup.
Hi @omakoleg :) Thanks for opening this one. We're fully open for a PR on this to either remove the link or replace it with a more up to date...
Can you please share a minimal reproduction for us to help?
> @MatanBobi Would you consider this as a blocker for this PR? In any case I think we can reuse the same approach as RTL where they check if globals...
Hi @enmanuelduran, thanks for taking the time to document this. I'm leaning towards not changing the implementation as we're following the spec and if we'd start diverging from it, we'll...