Matan Borenkraout

@eps1lon Wdyt about making this change as part of a major too? https://github.com/testing-library/react-testing-library/issues/1277 Also, here's the PR to move DTL to peer: https://github.com/testing-library/react-testing-library/pull/1309

> Just push this commit to this branch. I don't want to go through the alpha branch shenanigans and just ship the major with one PR. Done. I haven't fixed...

@eps1lon Do we want to push this one forwards after seeing that the latest major release looks ok?

Thanks @eps1lon. I've merged from `main` and fixed the conflicts we had so this is ready to be merged IMO.

> Does `feat!` do anything for semantic-release? AFAIU no, it only uses the `BREAKING CHANGE` commit message, though I'm trying to follow conventional commit messages: https://www.conventionalcommits.org/en/v1.0.0/#commit-message-with--to-draw-attention-to-breaking-change You can feel free...

This is usually happening due to multiple instances of @testing-library/dom which is a peer dependency of user-event and a dependency for RTL. Try resolving to one version using npm overrides...

@belozerov The warning you see here is related to a bug in React's release where they didn't export `act` but only `unstable_act` as can be seen here: https://github.com/testing-library/react-testing-library/issues/1314. @brandanking-decently -...

I'm resolving this as a new version of RTL was released where DTL is a peer dependency so it should resolve it. If you're still experiencing this, please re-open or...

This is interesting, thanks for reporting. I've verified that this indeed doesn't happen in React Test Renderer: https://stackblitz.com/edit/rtl-template-4fhhup?file=src%2FApp.test.tsx,package.json Having said that, I'm not sure this is related to our implementation...

@huntercaron any chance for a review on this one please? :)